[flang-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)
Joseph Huber via flang-commits
flang-commits at lists.llvm.org
Fri Feb 7 07:34:51 PST 2025
jhuber6 wrote:
> So I should do like open 5 branches and make a PR for each?
>
> As for the cases mentioned, when I tried compile all projects (compile with -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and I've fixed them all. Now all projects can be successfully built, so I think it should be fine?
Yes, one PR for each project please.
Also refer to the failing CI for what's broken, e.g.
```
/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-96x6s-1/llvm-project/github-pull-requests/flang/lib/Lower/OpenMP/Utils.cpp:30:28: error: static declaration of 'treatIndexAsSection' follows non-static declaration
static llvm::cl::opt<bool> treatIndexAsSection(
^
/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-96x6s-1/llvm-project/github-pull-requests/flang/lib/Lower/OpenMP/Utils.h:19:28: note: previous declaration is here
extern llvm::cl::opt<bool> treatIndexAsSection;
^
```
https://github.com/llvm/llvm-project/pull/126243
More information about the flang-commits
mailing list