[flang-commits] [flang] [llvm] [flang][OpenMP] Semantic checks for context selectors (PR #123243)

Mon Feb 3 08:16:00 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` running on `linaro-flang-aarch64-libcxx` while building `flang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/builds/15800

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
1025.342 [186/43/7093] Linking CXX executable bin/llvm-xray
1025.345 [186/42/7094] Linking CXX executable bin/llvm-reduce
1025.358 [186/41/7095] Linking CXX executable bin/llvm-split
1039.060 [186/40/7096] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/program-tree.cpp.o
1040.586 [186/39/7097] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-select-rank.cpp.o
1043.743 [186/38/7098] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-declarations.cpp.o
1050.065 [186/37/7099] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-data.cpp.o
1052.943 [186/36/7100] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/definable.cpp.o
1056.030 [186/35/7101] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-io.cpp.o
1056.043 [178/42/7102] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-omp-structure.cpp.o
FAILED: tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-omp-structure.cpp.o 
/usr/local/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/flang/lib/Semantics -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/lib/Semantics -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/flang/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/../mlir/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/mlir/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/clang/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/../clang/include -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-omp-structure.cpp.o -MF tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-omp-structure.cpp.o.d -o tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-omp-structure.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/lib/Semantics/check-omp-structure.cpp
../llvm-project/flang/lib/Semantics/check-omp-structure.cpp:4728:32: error: captured structured bindings are a C++20 extension [-Werror,-Wc++20-extensions]
 4728 |                   context_.Say(traitName.source,
      |                                ^
../llvm-project/flang/lib/Semantics/check-omp-structure.cpp:4721:14: note: 'traitName' declared here
 4721 |       auto &[traitName, maybeProps]{trait.t};
      |              ^
../llvm-project/flang/lib/Semantics/check-omp-structure.cpp:4735:32: error: captured structured bindings are a C++20 extension [-Werror,-Wc++20-extensions]
 4735 |                   context_.Say(traitName.source,
      |                                ^
../llvm-project/flang/lib/Semantics/check-omp-structure.cpp:4721:14: note: 'traitName' declared here
 4721 |       auto &[traitName, maybeProps]{trait.t};
      |              ^
../llvm-project/flang/lib/Semantics/check-omp-structure.cpp:4742:32: error: captured structured bindings are a C++20 extension [-Werror,-Wc++20-extensions]
 4742 |                   context_.Say(traitName.source,
      |                                ^
../llvm-project/flang/lib/Semantics/check-omp-structure.cpp:4721:14: note: 'traitName' declared here
 4721 |       auto &[traitName, maybeProps]{trait.t};
      |              ^
3 errors generated.
1056.101 [178/41/7103] Linking CXX shared module unittests/Passes/Plugins/DoublerPlugin.so
1056.104 [178/40/7104] Linking CXX shared module unittests/Analysis/InlineOrderPlugin.so
1056.118 [178/39/7105] Linking CXX shared module unittests/Passes/Plugins/TestPlugin.so
1056.119 [178/38/7106] Linking CXX shared library lib/libbenchmark.so.0.0.0
1056.144 [178/37/7107] Linking CXX executable bin/llvm-size
1056.164 [178/36/7108] Linking CXX executable bin/llvm-tli-checker
1056.168 [178/35/7109] Linking CXX executable bin/llvm-strings
1056.172 [178/34/7110] Linking CXX executable bin/llvm-symbolizer
1059.805 [178/33/7111] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-case.cpp.o
1067.464 [178/32/7112] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/data-to-inits.cpp.o
1068.967 [178/31/7113] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/pointer-assignment.cpp.o
1069.351 [178/30/7114] Building CXX object tools/flang/tools/flang-driver/CMakeFiles/flang.dir/fc1_main.cpp.o
1069.878 [178/29/7115] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/resolve-labels.cpp.o
1071.104 [178/28/7116] Building CXX object tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/CompilerInstance.cpp.o
1075.166 [178/27/7117] Building CXX object tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/FrontendAction.cpp.o
1076.078 [178/26/7118] Building CXX object tools/flang/lib/FrontendTool/CMakeFiles/flangFrontendTool.dir/ExecuteCompilerInvocation.cpp.o
1078.373 [178/25/7119] Building CXX object tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/Runtime/Intrinsics.cpp.o
1086.560 [178/24/7120] Building CXX object tools/flang/lib/Semantics/CMakeFiles/FortranSemantics.dir/check-coarray.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/123243