[flang-commits] [flang] [flang] Fix issue when macro is followed by OpenMP pragma (PR #123035)
via flang-commits
flang-commits at lists.llvm.org
Sat Feb 1 22:05:30 PST 2025
shivaramaarao wrote:
I do see more cases to be handled. currently for the source lines that begins with MACRO, characters after "!" are discarded and many issues are hidden.
We need to handle
a) comments after compiler directives
e.g MACRO !$ OMP <stmt> <comment line>
b) conditional statements
e.g MACRO !$ ndim=0
c) continuation lines
e.g MACRO !$OMP <stmt > !comment &
MACRO !$OMP <stmt>
d) compiler directives that are actually comments
MACRO !$OMP <stmt> !$OMP <stmt>
When I was looking into the code, I feel we might need to make design changes to existing implementation that handles macro replacement to consider all these cases. Can someone please comment on this?
https://github.com/llvm/llvm-project/pull/123035
More information about the flang-commits
mailing list