[flang-commits] [flang] [flang] Allow extended char set in `BIND(C, name="...")` (PR #172457)

[via flang-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=4294967295] tools/flang/unittests/Optimizer/FlangOptimizerTests.exe</summary>

```
FAILED: [code=4294967295] tools/flang/unittests/Optimizer/FlangOptimizerTests.exe
cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --intdir=tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\FlangOptimizerTests.rsp  /out:tools\flang\unittests\Optimizer\FlangOptimizerTests.exe /implib:tools\flang\unittests\Optimizer\FlangOptimizerTests.lib /pdb:tools\flang\unittests\Optimizer\FlangOptimizerTests.pdb /version:0.0 /MANIFEST:NO /STACK:10000000 /INCREMENTAL:NO /subsystem:console  && cd ."
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\FlangOptimizerTests.rsp /out:tools\flang\unittests\Optimizer\FlangOptimizerTests.exe /implib:tools\flang\unittests\Optimizer\FlangOptimizerTests.lib /pdb:tools\flang\unittests\Optimizer\FlangOptimizerTests.pdb /version:0.0 /MANIFEST:NO /STACK:10000000 /INCREMENTAL:NO /subsystem:console" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: private: static class mlir::SelfOwningTypeID mlir::detail::TypeIDResolver<class mlir::LLVM::LLVMDialect, void>::id
>>> referenced by tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir\Builder\CharacterTest.cpp.obj:(void __cdecl fir::support::registerDialects(class mlir::DialectRegistry &))
>>> referenced by tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir\Builder\CharacterTest.cpp.obj:(private: virtual class mlir::Dialect * __cdecl std::_Func_impl_no_alloc<class `public: void __cdecl mlir::DialectRegistry::insert<class mlir::LLVM::LLVMDialect>(void)'::`1'::<lambda_1>, class mlir::Dialect *, class mlir::MLIRContext *>::_Do_call(class mlir::MLIRContext *&&))
>>> referenced by tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir\Builder\CharacterTest.cpp.obj:(public: void __cdecl mlir::MLIRContext::loadDialect<class mif::MIFDialect, class fir::FIRCodeGenDialect, class mlir::LLVM::LLVMDialect>(void))
>>> referenced 5 more times

lld-link: error: undefined symbol: private: __cdecl mlir::LLVM::LLVMDialect::LLVMDialect(class mlir::MLIRContext *)
>>> referenced by tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir\Builder\CharacterTest.cpp.obj:(private: static class std::unique_ptr<class mlir::Dialect, struct std::default_delete<class mlir::Dialect>> __cdecl llvm::function_ref<class std::unique_ptr<class mlir::Dialect, struct std::default_delete<class mlir::Dialect>> __cdecl(void)>::callback_fn<class `public: class mlir::LLVM::LLVMDialect * __cdecl mlir::MLIRContext::getOrLoadDialect<class mlir::LLVM::LLVMDialect>(void)'::`1'::<lambda_1>>(__int64))
>>> referenced by tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir\Builder\ComplexTest.cpp.obj
>>> referenced by tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir\Builder\DoLoopHelperTest.cpp.obj

lld-link: error: undefined symbol: public: class llvm::ArrayRef<class mlir::StringAttr> __cdecl mlir::LLVM::TargetFeaturesAttr::getFeatures(void) const
>>> referenced by tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir\FIRContextTest.cpp.obj:(private: virtual void __cdecl StringAttributesTests_moduleStringAttrTest_Test::TestBody(void))

lld-link: error: undefined symbol: public: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl mlir::LLVM::TargetFeaturesAttr::getFeaturesString(void) const
>>> referenced by tools\flang\unittests\Optimizer\CMakeFiles\FlangOptimizerTests.dir\FIRContextTest.cpp.obj:(private: virtual void __cdecl StringAttributesTests_moduleStringAttrTest_Test::TestBody(void))

lld-link: error: undefined symbol: public: static class mlir::LLVM::LLVMPointerType __cdecl mlir::LLVM::LLVMPointerType::get(class mlir::MLIRContext *, unsigned int)
>>> referenced by FIRBuilder.lib(FIRBuilder.cpp.obj):(public: class mlir::Value __cdecl fir::FirOpBuilder::genStackSave(class mlir::Location))
>>> referenced by FIRBuilder.lib(FIRBuilder.cpp.obj):(class mlir::Value __cdecl fir::factory::genLifetimeStart(class mlir::OpBuilder &, class mlir::Location, class fir::AllocaOp, class mlir::DataLayout const *))
>>> referenced by FIRBuilder.lib(Character.cpp.obj):(public: void __cdecl fir::factory::CharacterExprHelper::createCopy(class fir::CharBoxValue const &, class fir::CharBoxValue const &, class mlir::Value))
>>> referenced 9 more times

lld-link: error: undefined symbol: public: static class mlir::LLVM::StackSaveOp __cdecl mlir::LLVM::StackSaveOp::create(class mlir::OpBuilder &, class mlir::Location, class mlir::Type)
>>> referenced by FIRBuilder.lib(FIRBuilder.cpp.obj):(public: class mlir::Value __cdecl fir::FirOpBuilder::genStackSave(class mlir::Location))
>>> referenced by MLIRLLVMIRTransforms.lib(InlinerInterfaceImpl.cpp.obj):(public: virtual void __cdecl `anonymous namespace'::LLVMInlinerInterface::processInlinedCallBlocks(class mlir::Operation *, class llvm::iterator_range<class llvm::ilist_iterator<struct llvm::ilist_detail::node_options<class mlir::Block, 1, 0, void, 0, void>, 0, 0>>) const)

lld-link: error: undefined symbol: public: static class mlir::LLVM::StackRestoreOp __cdecl mlir::LLVM::StackRestoreOp::create(class mlir::OpBuilder &, class mlir::Location, class mlir::Value)
>>> referenced by FIRBuilder.lib(FIRBuilder.cpp.obj):(public: void __cdecl fir::FirOpBuilder::genStackRestore(class mlir::Location, class mlir::Value))
>>> referenced by MLIRLLVMIRTransforms.lib(InlinerInterfaceImpl.cpp.obj):(public: virtual void __cdecl `anonymous namespace'::LLVMInlinerInterface::processInlinedCallBlocks(class mlir::Operation *, class llvm::iterator_range<class llvm::ilist_iterator<struct llvm::ilist_detail::node_options<class mlir::Block, 1, 0, void, 0, void>, 0, 0>>) const)

lld-link: error: undefined symbol: public: static class mlir::LLVM::LinkageAttr __cdecl mlir::LLVM::LinkageAttr::get(class mlir::MLIRContext *, enum mlir::LLVM::linkage::Linkage)
>>> referenced by FIRBuilder.lib(FIRBuilder.cpp.obj):(void __cdecl fir::factory::setInternalLinkage(class mlir::func::FuncOp))

lld-link: error: undefined symbol: public: static class mlir::LLVM::LifetimeStartOp __cdecl mlir::LLVM::LifetimeStartOp::create(class mlir::OpBuilder &, class mlir::Location, class mlir::Value)
>>> referenced by FIRBuilder.lib(FIRBuilder.cpp.obj):(class mlir::Value __cdecl fir::factory::genLifetimeStart(class mlir::OpBuilder &, class mlir::Location, class fir::AllocaOp, class mlir::DataLayout const *))
>>> referenced by MLIRLLVMIRTransforms.lib(InlinerInterfaceImpl.cpp.obj):(public: virtual void __cdecl `anonymous namespace'::LLVMInlinerInterface::processInlinedCallBlocks(class mlir::Operation *, class llvm::iterator_range<class llvm::ilist_iterator<struct llvm::ilist_detail::node_options<class mlir::Block, 1, 0, void, 0, void>, 0, 0>>) const)

lld-link: error: undefined symbol: public: static class mlir::LLVM::LifetimeEndOp __cdecl mlir::LLVM::LifetimeEndOp::create(class mlir::OpBuilder &, class mlir::Location, class mlir::Value)
>>> referenced by FIRBuilder.lib(FIRBuilder.cpp.obj):(void __cdecl fir::factory::genLifetimeEnd(class mlir::OpBuilder &, class mlir::Location, class mlir::Value))
>>> referenced by MLIRLLVMIRTransforms.lib(InlinerInterfaceImpl.cpp.obj):(public: virtual void __cdecl `anonymous namespace'::LLVMInlinerInterface::processInlinedCallBlocks(class mlir::Operation *, class llvm::iterator_range<class llvm::ilist_iterator<struct llvm::ilist_detail::node_options<class mlir::Block, 1, 0, void, 0, void>, 0, 0>>) const)

lld-link: error: undefined symbol: public: static class mlir::LLVM::MemmoveOp __cdecl mlir::LLVM::MemmoveOp::create(class mlir::OpBuilder &, class mlir::Location, class mlir::Value, class mlir::Value, class mlir::Value, bool)
>>> referenced by FIRBuilder.lib(Character.cpp.obj):(public: void __cdecl fir::factory::CharacterExprHelper::createCopy(class fir::CharBoxValue const &, class fir::CharBoxValue const &, class mlir::Value))

lld-link: error: undefined symbol: public: static class mlir::LLVM::LoopVectorizeAttr __cdecl mlir::LLVM::LoopVectorizeAttr::get(class mlir::MLIRContext *, class mlir::BoolAttr, class mlir::BoolAttr, class mlir::BoolAttr, class mlir::IntegerAttr, class mlir::LLVM::LoopAnnotationAttr, class mlir::LLVM::LoopAnnotationAttr, class mlir::LLVM::LoopAnnotationAttr)
>>> referenced by FIRBuilder.lib(HLFIRTools.cpp.obj):(struct hlfir::LoopNest __cdecl hlfir::genLoopNest(class mlir::Location, class fir::FirOpBuilder &, class mlir::ValueRange, bool, bool, bool))

lld-link: error: undefined symbol: public: static class mlir::LLVM::LoopAnnotationAttr __cdecl mlir::LLVM::LoopAnnotationAttr::get(class mlir::MLIRContext *, class mlir::BoolAttr, class mlir::LLVM::LoopVectorizeAttr, class mlir::LLVM::LoopInterleaveAttr, class mlir::LLVM::LoopUnrollAttr, class mlir::LLVM::LoopUnrollAndJamAttr, class mlir::LLVM::LoopLICMAttr, class mlir::LLVM::LoopDistributeAttr, class mlir::LLVM::LoopPipelineAttr, class mlir::LLVM::LoopPeeledAttr, class mlir::LLVM::LoopUnswitchAttr, class mlir::BoolAttr, class mlir::BoolAttr, class mlir::FusedLoc, class mlir::FusedLoc, class llvm::ArrayRef<class mlir::LLVM::AccessGroupAttr>)
>>> referenced by FIRBuilder.lib(HLFIRTools.cpp.obj):(struct hlfir::LoopNest __cdecl hlfir::genLoopNest(class mlir::Location, class fir::FirOpBuilder &, class mlir::ValueRange, bool, bool, bool))
>>> referenced by MLIRLLVMIRTransforms.lib(InlinerInterfaceImpl.cpp.obj):(private: virtual class std::optional<struct std::pair<class mlir::Attribute, class mlir::WalkResult>> __cdecl std::_Func_impl_no_alloc<class `public: void __cdecl mlir::detail::AttrTypeReplacerBase<class mlir::AttrTypeReplacer>::addReplacement<class `void __cdecl handleLoopAnnotations(class mlir::Operation *, class llvm::iterator_range<class llvm::ilist_iterator<struct llvm::ilist_detail::node_options<class mlir::Block, 1, 0, void, 0, void>, 0, 0>>)'::`1'::<lambda_4>, class mlir::LLVM::LoopAnnotationAttr, class mlir::Attribute, struct std::pair<class mlir::Attribute, class mlir::WalkResult>>(class `void __cdecl handleLoopAnnotations(class mlir::Operation *, class llvm::iterator_range<class llvm::ilist_iterator<struct llvm::ilist_detail::node_options<class mlir::Block, 1, 0, void, 0, void>, 0, 0>>)'::`1'::<lambda_4> &&)'::`1'::<lambda_1>, class std::optional<struct std::pair<class mlir::Attribute, class mlir::WalkResult>>, class mlir::Attribute>::_Do_call(class mlir::Attribute &&))

lld-link: error: undefined symbol: private: static class mlir::SelfOwningTypeID mlir::detail::TypeIDResolver<class mlir::LLVM::LLVMPointerType, void>::id
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(bool __cdecl llvm::isa<class fir::ReferenceType, class fir::PointerType, class fir::HeapType, class fir::LLVMPointerType, class mlir::MemRefType, class mlir::FunctionType, class fir::TypeDescType, class mlir::LLVM::LLVMPointerType, class mlir::Type>(class mlir::Type const &))
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: struct llvm::LogicalResult __cdecl fir::ConvertOp::verify(void))
>>> referenced by MLIRLLVMIRTransforms.lib(InlinerInterfaceImpl.cpp.obj):(public: virtual class mlir::Value __cdecl `anonymous namespace'::LLVMInlinerInterface::handleArgument(class Value::OpBuilder &, class Value::Operation *, class Value::Operation *, class Value::0x4CCC2398, class Value::DictionaryAttr) const)
>>> referenced 183 more times

lld-link: error: undefined symbol: public: class mlir::Attribute __cdecl mlir::LLVM::ConstantOp::getValue(void)
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(class std::optional<__int64> __cdecl fir::getIntIfConstant(class mlir::Value))

lld-link: error: undefined symbol: private: static class mlir::SelfOwningTypeID mlir::detail::TypeIDResolver<class mlir::LLVM::AccessGroupAttr, void>::id
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: struct llvm::LogicalResult __cdecl fir::CallOpAdaptor::verify(class mlir::Location))
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(struct llvm::LogicalResult __cdecl __mlir_ods_local_attr_constraint_FIROps10(class mlir::Attribute, class llvm::StringRef, class llvm::function_ref<class mlir::InFlightDiagnostic __cdecl(void)>))
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: struct llvm::LogicalResult __cdecl fir::LoadOpAdaptor::verify(class mlir::Location))
>>> referenced 1 more times

lld-link: error: undefined symbol: private: static class mlir::SelfOwningTypeID mlir::detail::TypeIDResolver<class mlir::LLVM::LoopAnnotationAttr, void>::id
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: static struct llvm::LogicalResult __cdecl fir::DoConcurrentLoopOp::setPropertiesFromAttr(struct fir::detail::DoConcurrentLoopOpGenericAdaptorBase::Properties &, class mlir::Attribute, class llvm::function_ref<class mlir::InFlightDiagnostic __cdecl(void)>))
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: static struct llvm::LogicalResult __cdecl fir::DoConcurrentLoopOp::setPropertiesFromAttr(struct fir::detail::DoConcurrentLoopOpGenericAdaptorBase::Properties &, class mlir::Attribute, class llvm::function_ref<class mlir::InFlightDiagnostic __cdecl(void)>))
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: static void __cdecl fir::DoConcurrentLoopOp::setInherentAttr(struct fir::detail::DoConcurrentLoopOpGenericAdaptorBase::Properties &, class llvm::StringRef, class mlir::Attribute))
>>> referenced 12 more times

lld-link: error: undefined symbol: private: static class mlir::SelfOwningTypeID mlir::detail::TypeIDResolver<class mlir::LLVM::TBAATagAttr, void>::id
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: struct llvm::LogicalResult __cdecl fir::LoadOpAdaptor::verify(class mlir::Location))
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(struct llvm::LogicalResult __cdecl __mlir_ods_local_attr_constraint_FIROps29(class mlir::Attribute, class llvm::StringRef, class llvm::function_ref<class mlir::InFlightDiagnostic __cdecl(void)>))
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: struct llvm::LogicalResult __cdecl fir::StoreOpAdaptor::verify(class mlir::Location))
>>> referenced 1 more times

lld-link: error: undefined symbol: private: static class mlir::SelfOwningTypeID mlir::detail::TypeIDResolver<class mlir::LLVM::ConstantOp, void>::id
>>> referenced by FIRDialect.lib(FIROps.cpp.obj):(public: static bool __cdecl mlir::Op<class mlir::LLVM::ConstantOp, class mlir::OpTrait::ZeroRegions, class mlir::OpTrait::OneResult, class mlir::OpTrait::OneTypedResult<class mlir::Type>::Impl, class mlir::OpTrait::ZeroSuccessors, class mlir::OpTrait::ZeroOperands, class mlir::OpTrait::OpInvariants, struct mlir::BytecodeOpInterface::Trait, struct mlir::ConditionallySpeculatable::Trait, struct mlir::OpTrait::AlwaysSpeculatableImplTrait, struct mlir::MemoryEffectOpInterface::Trait, class mlir::OpTrait::ConstantLike>::classof(class mlir::Operation *))

lld-link: error: undefined symbol: public: static class mlir::LLVM::TargetFeaturesAttr __cdecl mlir::LLVM::TargetFeaturesAttr::get(class mlir::MLIRContext *, class llvm::StringRef)
>>> referenced by FIRDialectSupport.lib(FIRContext.cpp.obj):(void __cdecl fir::setTargetFeatures(class mlir::ModuleOp, class llvm::StringRef))

lld-link: error: too many errors emitted, stopping now (use /errorlimit:0 to see all errors)
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/172457