[flang-commits] [clang] [flang] [lld] [llvm] Test entry-points for pass-plugins with Bye in clang, flang and lld (PR #172463)

[Nikita Popov via flang-commits]

https://github.com/nikic commented:

I'd rather not have these tests duplicated across different tools in different projects. Changing pass builder callbacks should not require changes to flang tests.

Shouldn't testing these via `opt` be sufficient? I.e. test the various pipelines (`default<O0>`, `default<O3>`, `thinlto-pre-link<O3>`, `lto-pre-link<O3>`, `thinlto<O3>`, `lto<O3>`) with the plugin. Frontends then invoke those pipelines.

It looks like some of the callbacks are also missing here, e.g. the loop ones?

-----

As to which callbacks *should* get invoked, yeah, that's somewhat messy. I think `O0` should be running less callbacks than it does (it mainly needs extension points for mandatory instrumentation), and ideally we'd not have separate LTO callbacks and instead of normal ones with appropriate LTOPhase.

https://github.com/llvm/llvm-project/pull/172463