[flang-commits] [flang] [llvm] [flang][MIF] Adding Stop and ErrorStop operations (PR #166787)

[Dan Bonachea via flang-commits]

================
@@ -93,10 +93,20 @@ RT_API_ATTRS void Terminator::CrashHeader() const {
       sourceFileName_, sourceLine_);
 }
 
-// TODO: These will be defined in the coarray runtime library
-RT_API_ATTRS void NotifyOtherImagesOfNormalEnd() {}
-RT_API_ATTRS void NotifyOtherImagesOfFailImageStatement() {}
-RT_API_ATTRS void NotifyOtherImagesOfErrorTermination() {}
+RT_API_ATTRS void NotifyOtherImagesOfNormalEnd() {
----------------
bonachea wrote:

This is a purely cosmetic suggestion, but it might improve clarity to rename this callback to emphasize that it both communicates and synchronizes. Eg:

```suggestion
RT_API_ATTRS void SynchronizeImagesForNormalTermination() {
```

https://github.com/llvm/llvm-project/pull/166787