[flang-commits] [flang] [flang][OpenMP] Fix regression in OpenMP master region with private t… (PR #172085)

[Priyanshu Singh via flang-commits]

================
@@ -702,20 +702,24 @@ void AddAliasTagsPass::runOnAliasInterface(fir::FirAliasTagOpInterface op,
              source.kind == fir::AliasAnalysis::SourceKind::Argument) {
     LLVM_DEBUG(llvm::dbgs().indent(2)
                << "Found reference to dummy argument at " << *op << "\n");
-    std::string name = getFuncArgName(llvm::cast<mlir::Value>(source.origin.u));
     // POINTERS can alias with any POINTER or TARGET. Assume that TARGET dummy
     // arguments might alias with each other (because of the "TARGET" hole for
     // dummy arguments). See flang/docs/Aliasing.md.
+    // If it is a TARGET or POINTER, then we do not care about the name,
+    // because the tag points to the root of the subtree currently.
----------------
dev-priyanshu15 wrote:

Thanks for catching that! I've updated the comment to better reflect the current behavior. 
The new comment now says:

// If it is a TARGET or POINTER, use the target data tree tag which 
// represents potential aliases with other TARGET/POINTER variables.

This is more accurate than the previous wording and reflects the changes from PR #170908. 
The updated commit has been force-pushed.

https://github.com/llvm/llvm-project/pull/172085