[flang-commits] [flang] [flang] Improve intrinsic error messages when multiple signatures exist (PR #172099)

[Eugene Epshteyn via flang-commits]

eugeneepshteyn wrote:

@tmjbios , it seems that your change will also affect other tests. Please run all LIT tests to ensure that no other tests start failing.
```
$ grep -ri "too many actual arguments for intrinsic"
Semantics/coshape.f90:  !ERROR: too many actual arguments for intrinsic 'coshape'
Semantics/failed_images.f90:  !ERROR: too many actual arguments for intrinsic 'failed_images'
Semantics/stopped_images.f90:  !ERROR: too many actual arguments for intrinsic 'stopped_images'
Semantics/image_status.f90:  !ERROR: too many actual arguments for intrinsic 'image_status'
Semantics/this_image02.f90:  !ERROR: too many actual arguments for intrinsic 'this_image'
Semantics/image_index02.f90:  !ERROR: too many actual arguments for intrinsic 'image_index'
Semantics/image_index02.f90:  !ERROR: too many actual arguments for intrinsic 'image_index'
Semantics/atomic02.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_and'
Semantics/team_number02.f90:  !ERROR: too many actual arguments for intrinsic 'team_number'
Semantics/atomic03.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_cas'
Semantics/atomic05.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_fetch_add'
Semantics/atomic06.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_fetch_and'
Semantics/team_number01.f90:  !ERROR: too many actual arguments for intrinsic 'team_number'
Semantics/atomic08.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_fetch_xor'
Semantics/move_alloc.f90:  !ERROR: too many actual arguments for intrinsic 'move_alloc'
Semantics/atomic11.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_xor'
Semantics/atomic09.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_or'
Semantics/event_query.f90:  ! ERROR: too many actual arguments for intrinsic 'event_query'
Semantics/atomic07.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_fetch_or'
Semantics/num_images02.f90:  !ERROR: too many actual arguments for intrinsic 'num_images'
Semantics/num_images02.f90:  !ERROR: too many actual arguments for intrinsic 'num_images'
Semantics/num_images02.f90:  !ERROR: too many actual arguments for intrinsic 'num_images'
Semantics/num_images01.f90:  !ERROR: too many actual arguments for intrinsic 'num_images'
Semantics/num_images01.f90:  !ERROR: too many actual arguments for intrinsic 'num_images'
Semantics/lcobound.f90:  !ERROR: too many actual arguments for intrinsic 'lcobound'
Semantics/atomic10.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_ref'
Semantics/get_team.f90:  !ERROR: too many actual arguments for intrinsic 'get_team'
Semantics/atomic04.f90:  !ERROR: too many actual arguments for intrinsic 'atomic_define'
Semantics/atomic01.f90:  ! ERROR: too many actual arguments for intrinsic 'atomic_add'
Semantics/ucobound.f90:  !ERROR: too many actual arguments for intrinsic 'ucobound'
```

https://github.com/llvm/llvm-project/pull/172099