[flang-commits] [flang] [flang][OpenMP] Parse OpenMP 6.0 syntax of INIT clause (PR #171702)

Krzysztof Parzyszek via flang-commits flang-commits at lists.llvm.org
Thu Dec 11 05:50:54 PST 2025


================
@@ -4031,27 +4031,43 @@ struct OmpFallbackModifier {
   WRAPPER_CLASS_BOILERPLATE(OmpFallbackModifier, Value);
 };
 
-// REF: [5.1:217-220], [5.2:293-294]
+// Ref: [6.0:470-471]
 //
-// OmpInteropRuntimeIdentifier ->                   // since 5.2
-// CharLiteralConstant || ScalarIntConstantExpr
-struct OmpInteropRuntimeIdentifier {
-  UNION_CLASS_BOILERPLATE(OmpInteropRuntimeIdentifier);
-  std::variant<CharLiteralConstant, ScalarIntConstantExpr> u;
+// preference-selector ->                           // since 6.0
+//    FR(foreign-runtime-identifier) |
----------------
kparzysz wrote:

I strongly prefer to use spec names, especially in comments (since they are not restricted by anything) to show the connection with the spec.  I changed the member type aliases to those from the spec instead, e.g. FRID -> ForeignRuntimeIdentifier, etc. (except for "Extensions" which does not have a corresponding name in the spec).

https://github.com/llvm/llvm-project/pull/171702


More information about the flang-commits mailing list