[flang-commits] [flang] [flang][docs] Do not recommend FLANG_ENABLE_WERROR=ON (PR #171152)
David Spickett via flang-commits
flang-commits at lists.llvm.org
Mon Dec 8 08:14:44 PST 2025
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/171152
Fixes #168911.
In which someone followed the getting started instructions but because they were using GCC and it produced some warnings, those got upgraded to errors and failed the build.
The GCC builds of anything in LLVM is always going to have some warning of some kind, so while it would be nice to fix or silence them, let's not inflict that on new developers.
This option is turned ON by a handful of bots, so if the intent was to make developers more attentive to warnings, that will still happen. Just a bit later, which that's better than putting them off up front.
>From 2f77786e0ca444ae160caeec8ae5f60af2bd571a Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Mon, 8 Dec 2025 16:08:22 +0000
Subject: [PATCH] [flang][docs] Do not reccomend FLANG_ENABLE_WERROR=ON
Fixes #168911.
In which someone followed the getting started instructions but
because they were using GCC and it produced some warnings, those
got upgraded to errors and failed the build.
The GCC builds of anything in LLVM is always going to have some
warning of some kind, so while it would be nice to fix or bypass
them, let's not inflict that on new developers.
This option is turned ON by a handful of bots, so if the intent
was to make developers more attentive to warnings, that will still
happen. Just a bit later, but that's better than putting them off
up front.
---
flang/docs/GettingStarted.md | 2 --
1 file changed, 2 deletions(-)
diff --git a/flang/docs/GettingStarted.md b/flang/docs/GettingStarted.md
index 2ea8093b607cf..5e29009b803ed 100644
--- a/flang/docs/GettingStarted.md
+++ b/flang/docs/GettingStarted.md
@@ -76,7 +76,6 @@ cmake \
-DCMAKE_INSTALL_PREFIX=$INSTALLDIR \
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DCMAKE_CXX_LINK_FLAGS="-Wl,-rpath,$LD_LIBRARY_PATH" \
- -DFLANG_ENABLE_WERROR=ON \
-DLLVM_ENABLE_ASSERTIONS=ON \
-DLLVM_TARGETS_TO_BUILD=host \
-DLLVM_LIT_ARGS=-v \
@@ -142,7 +141,6 @@ cmake \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_CXX_LINK_FLAGS="-Wl,-rpath,$LD_LIBRARY_PATH" \
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
- -DFLANG_ENABLE_WERROR=ON \
-DLLVM_TARGETS_TO_BUILD=host \
-DLLVM_ENABLE_ASSERTIONS=ON \
-DLLVM_BUILD_MAIN_SRC_DIR=$ROOTDIR/build/lib/cmake/llvm \
More information about the flang-commits
mailing list