[flang-commits] [flang] [flang][OpenMP] Move two functions to check-omp-loop.cpp, NFC (PR #170526)
Krzysztof Parzyszek via flang-commits
flang-commits at lists.llvm.org
Wed Dec 3 10:09:42 PST 2025
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/170526
These are checks for clauses that apply to loop constructs.
>From 962a21494ad714055ef1d0a8508f762bd56cfb3a Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
Date: Wed, 3 Dec 2025 12:05:22 -0600
Subject: [PATCH] [flang][OpenMP] Move two functions to check-omp-loop.cpp, NFC
These are checks for clauses that apply to loop constructs.
---
flang/lib/Semantics/check-omp-loop.cpp | 14 ++++++++++++++
flang/lib/Semantics/check-omp-structure.cpp | 15 ---------------
2 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/flang/lib/Semantics/check-omp-loop.cpp b/flang/lib/Semantics/check-omp-loop.cpp
index 9a78209369949..526e2d4658459 100644
--- a/flang/lib/Semantics/check-omp-loop.cpp
+++ b/flang/lib/Semantics/check-omp-loop.cpp
@@ -773,6 +773,20 @@ void OmpStructureChecker::Enter(const parser::OmpClause::Linear &x) {
}
}
+void OmpStructureChecker::Enter(const parser::OmpClause::Sizes &c) {
+ CheckAllowedClause(llvm::omp::Clause::OMPC_sizes);
+ for (const parser::Cosubscript &v : c.v)
+ RequiresPositiveParameter(llvm::omp::Clause::OMPC_sizes, v,
+ /*paramName=*/"parameter", /*allowZero=*/false);
+}
+
+void OmpStructureChecker::Enter(const parser::OmpClause::Looprange &x) {
+ CheckAllowedClause(llvm::omp::Clause::OMPC_looprange);
+ auto &[first, count]{x.v.t};
+ RequiresConstantPositiveParameter(llvm::omp::Clause::OMPC_looprange, count);
+ RequiresConstantPositiveParameter(llvm::omp::Clause::OMPC_looprange, first);
+}
+
void OmpStructureChecker::Enter(const parser::DoConstruct &x) {
Base::Enter(x);
loopStack_.push_back(&x);
diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index f7778472f71f1..f5883d30c492a 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -3393,21 +3393,6 @@ void OmpStructureChecker::Enter(const parser::OmpClause &x) {
}
}
-void OmpStructureChecker::Enter(const parser::OmpClause::Sizes &c) {
- CheckAllowedClause(llvm::omp::Clause::OMPC_sizes);
- for (const parser::Cosubscript &v : c.v)
- RequiresPositiveParameter(llvm::omp::Clause::OMPC_sizes, v,
- /*paramName=*/"parameter", /*allowZero=*/false);
-}
-
-void OmpStructureChecker::Enter(const parser::OmpClause::Looprange &x) {
- CheckAllowedClause(llvm::omp::Clause::OMPC_looprange);
- auto &first = std::get<0>(x.v.t);
- auto &count = std::get<1>(x.v.t);
- RequiresConstantPositiveParameter(llvm::omp::Clause::OMPC_looprange, count);
- RequiresConstantPositiveParameter(llvm::omp::Clause::OMPC_looprange, first);
-}
-
// Restrictions specific to each clause are implemented apart from the
// generalized restrictions.
More information about the flang-commits
mailing list