[flang-commits] [flang] [flang] Added storage specification for [hl]fir.declare. (PR #155325)

[Tom Eccles via flang-commits]

================
@@ -68,3 +68,30 @@ fir::FortranVariableOpInterface::verifyDeclareLikeOpImpl(mlir::Value memref) {
   }
   return mlir::success();
 }
+
+mlir::LogicalResult
+fir::detail::verifyFortranVariableStorageOpInterface(mlir::Operation *op) {
+  auto storageIface = mlir::cast<fir::FortranVariableStorageOpInterface>(op);
+  mlir::Value storage = storageIface.getStorage();
+  std::uint64_t storageOffset = storageIface.getStorageOffset();
+  if (!storage) {
+    if (storageOffset != 0)
+      op->emitOpError("storage offset specified without the storage reference");
----------------
tblah wrote:

```suggestion
      return op->emitOpError("storage offset specified without the storage reference");
```

https://github.com/llvm/llvm-project/pull/155325