[flang-commits] [flang] [Flang] Fix BUILD_SHARED_LIBS build (PR #155422)
Michael Kruse via flang-commits
flang-commits at lists.llvm.org
Tue Aug 26 07:26:29 PDT 2025
https://github.com/Meinersbur created https://github.com/llvm/llvm-project/pull/155422
In contrast to linking a static library, when linking a shared library all referenced symbols must be available in either the objects files, static libraries, or shared libraries passed to the linker command line and cannot be deferred to when building the executable.
We have buildbots that build with BUILD_SHARED_LIBS=ON such that new link symbol dependencies (e.g. by a new call of a non-inlined function from a header of another component) are detected post-commit, but we don't seem to have any for Flang, which means such build breakages may go unnoticed.
Fixes #150027
Same fix as included #152223, but with only the changes necessary to fix #150027.
>From 088cabc1805d0fef9e5401cc89c133f149a149dc Mon Sep 17 00:00:00 2001
From: Michael Kruse <llvm-project at meinersbur.de>
Date: Tue, 26 Aug 2025 16:11:29 +0200
Subject: [PATCH] Fix flang deps
---
flang/lib/Optimizer/Builder/CMakeLists.txt | 1 +
flang/lib/Optimizer/HLFIR/Transforms/CMakeLists.txt | 2 ++
2 files changed, 3 insertions(+)
diff --git a/flang/lib/Optimizer/Builder/CMakeLists.txt b/flang/lib/Optimizer/Builder/CMakeLists.txt
index 8fb36a750d433..404afd185fd31 100644
--- a/flang/lib/Optimizer/Builder/CMakeLists.txt
+++ b/flang/lib/Optimizer/Builder/CMakeLists.txt
@@ -50,6 +50,7 @@ add_flang_library(FIRBuilder
FIRDialectSupport
FIRSupport
FortranEvaluate
+ FortranSupport
HLFIRDialect
MLIR_DEPS
diff --git a/flang/lib/Optimizer/HLFIR/Transforms/CMakeLists.txt b/flang/lib/Optimizer/HLFIR/Transforms/CMakeLists.txt
index cc74273d9c5d9..3775a13e31e95 100644
--- a/flang/lib/Optimizer/HLFIR/Transforms/CMakeLists.txt
+++ b/flang/lib/Optimizer/HLFIR/Transforms/CMakeLists.txt
@@ -27,6 +27,8 @@ add_flang_library(HLFIRTransforms
FIRSupport
FIRTransforms
FlangOpenMPTransforms
+ FortranEvaluate
+ FortranSupport
HLFIRDialect
LINK_COMPONENTS
More information about the flang-commits
mailing list