[flang-commits] [flang] [mlir] [Flang][mlir] - Translation of delayed privatization for deferred target-tasks (PR #155348)

[via flang-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- mlir/include/mlir/Dialect/LLVMIR/Transforms/OpenMPOffloadPrivatizationPrepare.h mlir/lib/Dialect/LLVMIR/Transforms/OpenMPOffloadPrivatizationPrepare.cpp flang/include/flang/Optimizer/Passes/Pipelines.h flang/lib/Optimizer/Passes/Pipelines.cpp mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/lib/Optimizer/Passes/Pipelines.cpp b/flang/lib/Optimizer/Passes/Pipelines.cpp
index d9cb14262..6c9e0648f 100644
--- a/flang/lib/Optimizer/Passes/Pipelines.cpp
+++ b/flang/lib/Optimizer/Passes/Pipelines.cpp
@@ -414,9 +414,10 @@ void createMLIRToLLVMPassPipeline(mlir::PassManager &pm,
 
   // Run a pass to prepare for translation of delayed privatization in the
   // context of deferred target tasks.
-  addNestedPassConditionally<mlir::LLVM::LLVMFuncOp>(pm, disableFirToLlvmIr,[&]() {
-    return mlir::LLVM::createPrepareForOMPOffloadPrivatizationPass();
-  });
+  addNestedPassConditionally<mlir::LLVM::LLVMFuncOp>(
+      pm, disableFirToLlvmIr, [&]() {
+        return mlir::LLVM::createPrepareForOMPOffloadPrivatizationPass();
+      });
 }
 
 } // namespace fir
diff --git a/mlir/lib/Dialect/LLVMIR/Transforms/OpenMPOffloadPrivatizationPrepare.cpp b/mlir/lib/Dialect/LLVMIR/Transforms/OpenMPOffloadPrivatizationPrepare.cpp
index 3efdd5e14..e7ec5c737 100644
--- a/mlir/lib/Dialect/LLVMIR/Transforms/OpenMPOffloadPrivatizationPrepare.cpp
+++ b/mlir/lib/Dialect/LLVMIR/Transforms/OpenMPOffloadPrivatizationPrepare.cpp
@@ -7,8 +7,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "mlir/Analysis/SliceAnalysis.h"
 #include "mlir/Dialect/LLVMIR/Transforms/OpenMPOffloadPrivatizationPrepare.h"
+#include "mlir/Analysis/SliceAnalysis.h"
 #include "mlir/Dialect/Func/IR/FuncOps.h"
 #include "mlir/Dialect/LLVMIR/FunctionCallUtils.h"
 #include "mlir/Dialect/LLVMIR/LLVMDialect.h"
@@ -244,9 +244,8 @@ public:
       for (auto repl : replRecord) {
         Operation *origOp = repl.first;
         Operation *clonedOp = repl.second;
-        rewriter.modifyOpInPlace(clonedOp, [&]() {
-          clonedOp->replaceUsesOfWith(varPtr, heapMem);
-        });
+        rewriter.modifyOpInPlace(
+            clonedOp, [&]() { clonedOp->replaceUsesOfWith(varPtr, heapMem); });
         rewriter.eraseOp(origOp);
       }
     }
@@ -312,7 +311,7 @@ private:
   // Get the (compile-time constant) size of varType as per the
   // given DataLayout dl.
   std::int64_t getSizeInBytes(const mlir::DataLayout &dl,
-                           mlir::Type varType) const {
+                              mlir::Type varType) const {
     llvm::TypeSize size = dl.getTypeSize(varType);
     unsigned short alignment = dl.getTypeABIAlignment(varType);
     return llvm::alignTo(size, alignment);
@@ -350,7 +349,8 @@ private:
   LLVM::LLVMFuncOp getMalloc(ModuleOp mod, PatternRewriter &rewriter) const {
     llvm::FailureOr<mlir::LLVM::LLVMFuncOp> mallocCall =
         LLVM::lookupOrCreateMallocFn(rewriter, mod, rewriter.getI64Type());
-    assert(llvm::succeeded(mallocCall) && "Could not find malloc in the module");
+    assert(llvm::succeeded(mallocCall) &&
+           "Could not find malloc in the module");
     return mallocCall.value();
   }
 
@@ -372,8 +372,8 @@ private:
     mlir::Value sizeBytes = rewriter.create<LLVM::ConstantOp>(
         loc, mallocFn.getFunctionType().getParamType(0), distance);
 
-    auto mallocCallOp = rewriter.create<LLVM::CallOp>(loc, mallocFn,
-                                                      ValueRange{sizeBytes});
+    auto mallocCallOp =
+        rewriter.create<LLVM::CallOp>(loc, mallocFn, ValueRange{sizeBytes});
     return mallocCallOp.getResult();
   }
 
@@ -419,7 +419,6 @@ struct PrepareForOMPOffloadPrivatizationPass
       signalPassFailure();
     }
     LLVM_DEBUG(llvm::dbgs() << " Module after : " << mod << "\n");
-
   }
 };
 } // namespace

``````````

</details>


https://github.com/llvm/llvm-project/pull/155348