[flang-commits] [flang] [llvm] [Flang][OpenMP][Runtime] Minor Flang runtime for OpenMP AMDGPU (PR #152631)

[via flang-commits]

================
@@ -63,6 +73,24 @@
 #define STD_TOUPPER_UNSUPPORTED 1
 #endif
 
+#if defined(OMP_OFFLOAD_BUILD) || defined(OMP_NOHOST_BUILD)
----------------
agozillon wrote:

> Is it possible to add this only for the particular OpenMP compiler you are using currently? I think some other OpenMP compilers may support some of these STD methods, so I would prefer not to disable them all for all compilers that may be used for out-of-tree flang-rt builds.

That makes sense, I believe it should be possible, I think Clang (which is what we use) should have an environment variable specified during compilation to notify what compiler is in use, so should be able to use that if I'm remembering correctly.

> In addition, I think we should not do this for the host part of the offload build.

Makes sense as well, I'll change the || -> && and it should only be applicable to the offload build and fall back on the std or builtin implementations.


https://github.com/llvm/llvm-project/pull/152631