[flang-commits] [flang] [flang] Fix failure of regression tests on macOS (PR #151812)

[via flang-commits]

parabola94 wrote:

Thank you for your helpful comments.

> > Since there are only 3 tests that need `-isysroot`, another option is to not include it by default and add a new substitution, such as `%isysroot_flag`, and then use it only in the tests above.
> 
> IMHO, considering the `darwin-version.f90` issue, this seems the best option. The idea of adding `-isysroot` to `%flang` was to make things work transparently on macOS. But there are only a few tests that need it, and every now and then people forget about `%flang_fc1` and use `%flang -fc1` instead, which works on all other architectures.

This approach seems good to me as well. I closed this PR because my approach has some problems.

https://github.com/llvm/llvm-project/pull/151812