[flang-commits] [flang] [flang] Fix failure of regression tests on macOS (PR #151812)

[Michael Kruse via flang-commits]

https://github.com/Meinersbur commented:

Please avoid modifying substitutions after the fact. It is confusing if `%flang_fc1` means something in one test, but something else in another. Change https://github.com/llvm/llvm-project/blob/7cd1ce3aa006424d20e95a2a4fe7df7113527976/flang-rt/test/lit.cfg.py#L68 instead. If you need it to be different, add a new substitutions, such as `%flang_fc1_noisysroot` (or even better, only add `-isysroot` it to tests that need it).

Could you add details on when `-isysroot` is needed and when not? "some tests did not handle it appropriately" doesn't really explain anything. The change in `target-enter-data-default-openmp52.f90` also seems to be different.

https://github.com/llvm/llvm-project/pull/151812