[flang-commits] [flang] [Flang] Propogate fir.declare attributes through cg-rewrite (PR #137207)

[Razvan Lupusoru via flang-commits]

================
@@ -299,11 +299,16 @@ class DeclareOpConversion : public mlir::OpRewritePattern<fir::DeclareOp> {
       else
         return mlir::failure();
     }
-    // FIXME: Add FortranAttrs and CudaAttrs
+
     auto xDeclOp = rewriter.create<fir::cg::XDeclareOp>(
         loc, declareOp.getType(), declareOp.getMemref(), shapeOpers, shiftOpers,
         declareOp.getTypeparams(), declareOp.getDummyScope(),
         declareOp.getUniqName());
+
+    // attach metadatas from fir.declare to fircg.ext_declare
----------------
razvanlupusoru wrote:

I would update this comment to say something like:
"// Propagate all attributes to fircg.ext_declare to avoid losing metadata including CUDA and OpenACC attributes."

https://github.com/llvm/llvm-project/pull/137207