[flang-commits] [flang] [flang] Revamp evaluate::CoarrayRef (PR #136628)

[via flang-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- flang/include/flang/Evaluate/tools.h flang/include/flang/Evaluate/traverse.h flang/include/flang/Evaluate/variable.h flang/lib/Evaluate/check-expression.cpp flang/lib/Evaluate/fold.cpp flang/lib/Evaluate/formatting.cpp flang/lib/Evaluate/shape.cpp flang/lib/Evaluate/tools.cpp flang/lib/Evaluate/variable.cpp flang/lib/Lower/Support/Utils.cpp flang/lib/Semantics/check-coarray.cpp flang/lib/Semantics/check-coarray.h flang/lib/Semantics/dump-expr.cpp flang/lib/Semantics/expression.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/include/flang/Evaluate/tools.h b/flang/include/flang/Evaluate/tools.h
index 650c5b216..69b541dab 100644
--- a/flang/include/flang/Evaluate/tools.h
+++ b/flang/include/flang/Evaluate/tools.h
@@ -392,7 +392,7 @@ bool IsArrayElement(const Expr<T> &expr, bool intoSubstring = true,
     bool skipComponents = false) {
   if (auto dataRef{ExtractDataRef(expr, intoSubstring)}) {
     for (const DataRef *ref{&*dataRef}; ref;) {
-      if (const Component *component{std::get_if<Component>(&ref->u)}) {
+      if (const Component * component{std::get_if<Component>(&ref->u)}) {
         ref = skipComponents ? &component->base() : nullptr;
       } else if (const auto *coarrayRef{std::get_if<CoarrayRef>(&ref->u)}) {
         ref = &coarrayRef->base();
diff --git a/flang/lib/Evaluate/tools.cpp b/flang/lib/Evaluate/tools.cpp
index 16e2d6c0f..d39e4c429 100644
--- a/flang/lib/Evaluate/tools.cpp
+++ b/flang/lib/Evaluate/tools.cpp
@@ -1321,13 +1321,13 @@ std::optional<parser::MessageFixedText> CheckProcCompatibility(bool isCall,
 }
 
 const Symbol *UnwrapWholeSymbolOrComponentOrCoarrayRef(const DataRef &dataRef) {
-  if (const SymbolRef *p{std::get_if<SymbolRef>(&dataRef.u)}) {
+  if (const SymbolRef * p{std::get_if<SymbolRef>(&dataRef.u)}) {
     return &p->get();
-  } else if (const Component *c{std::get_if<Component>(&dataRef.u)}) {
+  } else if (const Component * c{std::get_if<Component>(&dataRef.u)}) {
     if (c->base().Rank() == 0) {
       return &c->GetLastSymbol();
     }
-  } else if (const CoarrayRef *c{std::get_if<CoarrayRef>(&dataRef.u)}) {
+  } else if (const CoarrayRef * c{std::get_if<CoarrayRef>(&dataRef.u)}) {
     return UnwrapWholeSymbolOrComponentOrCoarrayRef(c->base());
   }
   return nullptr;

``````````

</details>


https://github.com/llvm/llvm-project/pull/136628