[flang-commits] [flang] [mlir] [mlir] add a fluent API to GreedyRewriterConfig (PR #132253)

Fri Apr 18 06:28:49 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-release` running on `linaro-flang-aarch64-release` while building `flang,mlir` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/172/builds/12083

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
202.892 [910/49/5880] Building CXX object tools/mlir/lib/Transforms/Utils/CMakeFiles/obj.MLIRTransformUtils.dir/LoopInvariantCodeMotionUtils.cpp.o
203.037 [910/48/5881] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/LocationSnapshot.cpp.o
203.165 [910/47/5882] Building CXX object tools/mlir/lib/Transforms/Utils/CMakeFiles/obj.MLIRTransformUtils.dir/InliningUtils.cpp.o
203.282 [910/46/5883] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/ViewOpGraph.cpp.o
206.502 [910/45/5884] Linking CXX executable bin/llvm-lto
206.902 [910/44/5885] Linking CXX shared library lib/libLTO.so.21.0git
211.162 [910/43/5886] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/GenerateRuntimeVerification.cpp.o
212.927 [910/42/5887] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/ControlFlowSink.cpp.o
214.214 [910/41/5888] Building CXX object tools/mlir/lib/Dialect/Tosa/Transforms/CMakeFiles/obj.MLIRTosaTransforms.dir/TosaOptionalDecompositions.cpp.o
215.700 [910/40/5889] Building CXX object tools/mlir/lib/Transforms/Utils/CMakeFiles/obj.MLIRTransformUtils.dir/GreedyPatternRewriteDriver.cpp.o
FAILED: tools/mlir/lib/Transforms/Utils/CMakeFiles/obj.MLIRTransformUtils.dir/GreedyPatternRewriteDriver.cpp.o 
/usr/local/bin/c++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-release/build/tools/mlir/lib/Transforms/Utils -I/home/tcwg-buildbot/worker/flang-aarch64-release/llvm-project/mlir/lib/Transforms/Utils -I/home/tcwg-buildbot/worker/flang-aarch64-release/build/tools/mlir/include -I/home/tcwg-buildbot/worker/flang-aarch64-release/llvm-project/mlir/include -I/home/tcwg-buildbot/worker/flang-aarch64-release/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-release/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/mlir/lib/Transforms/Utils/CMakeFiles/obj.MLIRTransformUtils.dir/GreedyPatternRewriteDriver.cpp.o -MF tools/mlir/lib/Transforms/Utils/CMakeFiles/obj.MLIRTransformUtils.dir/GreedyPatternRewriteDriver.cpp.o.d -o tools/mlir/lib/Transforms/Utils/CMakeFiles/obj.MLIRTransformUtils.dir/GreedyPatternRewriteDriver.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-release/llvm-project/mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
../llvm-project/mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp:599:17: error: 'listener' is a private member of 'mlir::GreedyRewriteConfig'
  599 |     if (!config.listener) {
      |                 ^
../llvm-project/mlir/include/mlir/Transforms/GreedyPatternRewriteDriver.h:148:27: note: declared private here
  148 |   RewriterBase::Listener *listener = nullptr;
      |                           ^
1 error generated.
215.930 [910/39/5890] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/StripDebugInfo.cpp.o
216.781 [910/38/5891] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/SymbolDCE.cpp.o
216.878 [910/37/5892] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/PrintIR.cpp.o
216.952 [910/36/5893] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/TopologicalSort.cpp.o
217.021 [910/35/5894] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/CompositePass.cpp.o
217.321 [910/34/5895] Building CXX object tools/mlir/lib/Dialect/Shape/Transforms/CMakeFiles/obj.MLIRShapeOpsTransforms.dir/RemoveShapeConstraints.cpp.o
217.558 [910/33/5896] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/OpStats.cpp.o
217.747 [910/32/5897] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/LoopInvariantCodeMotion.cpp.o
217.980 [910/31/5898] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/Canonicalizer.cpp.o
218.738 [910/30/5899] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/CSE.cpp.o
219.668 [910/29/5900] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/InlinerPass.cpp.o
219.686 [910/28/5901] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/SCCP.cpp.o
219.714 [910/27/5902] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/SymbolPrivatize.cpp.o
220.077 [910/26/5903] Building CXX object tools/mlir/lib/Dialect/SCF/Transforms/CMakeFiles/obj.MLIRSCFTransforms.dir/ForToWhile.cpp.o
220.869 [910/25/5904] Building CXX object tools/mlir/lib/Reducer/CMakeFiles/obj.MLIRReduce.dir/ReductionTreePass.cpp.o
221.160 [910/24/5905] Building CXX object tools/mlir/lib/Dialect/SparseTensor/Transforms/CMakeFiles/obj.MLIRSparseTensorTransforms.dir/SparseSpaceCollapse.cpp.o
222.064 [910/23/5906] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/SROA.cpp.o
222.528 [910/22/5907] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/Mem2Reg.cpp.o
223.480 [910/21/5908] Building CXX object tools/mlir/lib/Transforms/CMakeFiles/obj.MLIRTransforms.dir/RemoveDeadValues.cpp.o
223.829 [910/20/5909] Building CXX object tools/mlir/lib/Dialect/SCF/Transforms/CMakeFiles/obj.MLIRSCFTransforms.dir/LoopCanonicalization.cpp.o
224.722 [910/19/5910] Building CXX object tools/mlir/lib/Dialect/SCF/Transforms/CMakeFiles/obj.MLIRSCFTransforms.dir/LoopSpecialization.cpp.o
224.769 [910/18/5911] Building CXX object tools/mlir/lib/Dialect/Tosa/Transforms/CMakeFiles/obj.MLIRTosaTransforms.dir/TosaLayerwiseConstantFoldPass.cpp.o
224.870 [910/17/5912] Building CXX object tools/mlir/lib/Dialect/Shape/Transforms/CMakeFiles/obj.MLIRShapeOpsTransforms.dir/OutlineShapeComputation.cpp.o
227.120 [910/16/5913] Building CXX object tools/mlir/lib/Dialect/Vector/Transforms/CMakeFiles/obj.MLIRVectorTransforms.dir/LowerVectorMask.cpp.o
228.402 [910/15/5914] Building CXX object tools/mlir/lib/Dialect/Vector/Transforms/CMakeFiles/obj.MLIRVectorTransforms.dir/LowerVectorMultiReduction.cpp.o
229.367 [910/14/5915] Building CXX object tools/mlir/lib/Dialect/Tosa/Transforms/CMakeFiles/obj.MLIRTosaTransforms.dir/TosaMakeBroadcastable.cpp.o
229.455 [910/13/5916] Building CXX object tools/mlir/lib/Dialect/XeGPU/Transforms/CMakeFiles/obj.MLIRXeGPUTransforms.dir/XeGPUFoldAliasOps.cpp.o
229.734 [910/12/5917] Building CXX object tools/mlir/lib/Dialect/SPIRV/Transforms/CMakeFiles/obj.MLIRSPIRVTransforms.dir/CanonicalizeGLPass.cpp.o
229.774 [910/11/5918] Building CXX object tools/mlir/lib/Dialect/SPIRV/Transforms/CMakeFiles/obj.MLIRSPIRVTransforms.dir/SPIRVWebGPUTransforms.cpp.o
230.329 [910/10/5919] Building CXX object tools/mlir/lib/Dialect/Tensor/Transforms/CMakeFiles/obj.MLIRTensorTransforms.dir/FoldTensorSubsetOps.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/132253