[flang-commits] [flang] [flang] Fix linking to libMLIR (PR #135483)
Michał Górny via flang-commits
flang-commits at lists.llvm.org
Mon Apr 14 09:46:23 PDT 2025
mgorny wrote:
> Thank you for the change! Can you please explain how the failure looks like? I did not see issues with my local builds using both static and shared libs, but I must have missed something.
Sure, lemme just build it again, since I didn't save the logs. That said, I'm pretty sure it was the usual linker about about `-lMLIRIR` not being found — since we install MLIR without static libraries.
> It looks like the `LINK_COMPONENTS` section needs to be hoisted above `MLIR_LIBS` - I think CMake code in AddFlang.cmake is not handling the ordering very well.
You are correct, sorry about that — pushed a fix.
https://github.com/llvm/llvm-project/pull/135483
More information about the flang-commits
mailing list