[flang-commits] [flang] [flang][OpenMP] Fix regression in !$ continuation (PR #134756)

[Peter Klausler via flang-commits]

klausler wrote:

Fix is ready, will merge today.

From: Robert Imschweiler ***@***.***>
Date: Monday, April 14, 2025 at 08:45
To: llvm/llvm-project ***@***.***>
Cc: Peter Klausler ***@***.***>, State change ***@***.***>
Subject: Re: [llvm/llvm-project] [flang][OpenMP] Fix regression in !$ continuation (PR #134756)

This commit (0ae9bb9<https://github.com/llvm/llvm-project/commit/0ae9bb96d5af47a2426596dbd0c35e3ff0cdddcc>) breaks building a SPEC openmp benchmark (https://www.spec.org/auto/omp2012/Docs/357.bt331.html). A reduced test case:

program BT

!$     integer  omp_get_max_threads

!$     external omp_get_max_threads



c---------------------------------------------------------------------

       write(*, '(A1)') ' '

       end

This leads to the following compile error:

$ flang -fopenmp -c bt.condcomp.f

error: Could not parse bt.condcomp.f

./bt.condcomp.f:1:1: warning: Character in fixed-form label field must be a digit

  program BT

  ^

./bt.condcomp.f:5:6: error: expected end of statement

  c---------------------------------------------------------------------

       ^

./bt.condcomp.f:3:8: in the context: specification construct

  !$     external omp_get_max_threads

         ^

./bt.condcomp.f:2:8: in the context: specification part

  !$     integer  omp_get_max_threads

         ^

—
Reply to this email directly, view it on GitHub<https://github.com/llvm/llvm-project/pull/134756#issuecomment-2802144426>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIRI5XPBYKGM6DDMNCF3Q4D2ZPJZRAVCNFSM6AAAAAB2U2RVDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGE2DINBSGY>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
[Image removed by sender.]ro-i left a comment (llvm/llvm-project#134756)<https://github.com/llvm/llvm-project/pull/134756#issuecomment-2802144426>

This commit (0ae9bb9<https://github.com/llvm/llvm-project/commit/0ae9bb96d5af47a2426596dbd0c35e3ff0cdddcc>) breaks building a SPEC openmp benchmark (https://www.spec.org/auto/omp2012/Docs/357.bt331.html). A reduced test case:

program BT

!$     integer  omp_get_max_threads

!$     external omp_get_max_threads



c---------------------------------------------------------------------

       write(*, '(A1)') ' '

       end

This leads to the following compile error:

$ flang -fopenmp -c bt.condcomp.f

error: Could not parse bt.condcomp.f

./bt.condcomp.f:1:1: warning: Character in fixed-form label field must be a digit

  program BT

  ^

./bt.condcomp.f:5:6: error: expected end of statement

  c---------------------------------------------------------------------

       ^

./bt.condcomp.f:3:8: in the context: specification construct

  !$     external omp_get_max_threads

         ^

./bt.condcomp.f:2:8: in the context: specification part

  !$     integer  omp_get_max_threads

         ^

—
Reply to this email directly, view it on GitHub<https://github.com/llvm/llvm-project/pull/134756#issuecomment-2802144426>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIRI5XPBYKGM6DDMNCF3Q4D2ZPJZRAVCNFSM6AAAAAB2U2RVDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGE2DINBSGY>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>


https://github.com/llvm/llvm-project/pull/134756