[flang-commits] [flang] [flang][OpenMP][HLFIR] Support vector subscripted array sections for DEPEND (PR #133892)

[Slava Zakharin via flang-commits]

vzakhari wrote:

Thank you for the changes, Tom!

It feels a bit hacky, but I think it is an acceptable reuse of the designator builder code.  At the same time, I wonder why you need to modify the operation definition at all.  It seems to be short-lived, and it should not reach the verification between the insertion and deleteion in your code.  Would that be possible to keep the operation definition unchanged, and have a comment in the OpenMP code saying that this is a non-standard usage of the operation, and that it will fail if we do not manage to erase it?

https://github.com/llvm/llvm-project/pull/133892