[flang-commits] [flang] [flang][nfc] Support volatility in Fir ops (PR #134858)

[Tom Eccles via flang-commits]

================
@@ -853,6 +855,16 @@ std::vector<mlir::Value> fir::ArrayLoadOp::getExtents() {
   return {};
 }
 
+void fir::ArrayLoadOp::getEffects(
+    llvm::SmallVectorImpl<
+        mlir::SideEffects::EffectInstance<mlir::MemoryEffects::Effect>>
+        &effects) {
+  effects.emplace_back(mlir::MemoryEffects::Read::get(),
+                       &getOperation()->getOpOperand(0),
----------------
tblah wrote:

nit: using the named accessors for the op operands would be clearer

https://github.com/llvm/llvm-project/pull/134858