[flang-commits] [flang] [flang][OpenMP][Lower] fix statement context cleanup insertion point (PR #133891)
Sergio Afonso via flang-commits
flang-commits at lists.llvm.org
Mon Apr 7 05:05:48 PDT 2025
================
@@ -1914,12 +1913,11 @@ static mlir::omp::LoopNestOp genLoopNestOp(
queue, item, clauseOps);
}
-static void genLoopOp(lower::AbstractConverter &converter,
- lower::SymMap &symTable,
- semantics::SemanticsContext &semaCtx,
- lower::pft::Evaluation &eval, mlir::Location loc,
- const ConstructQueue &queue,
- ConstructQueue::const_iterator item) {
+static mlir::Operation *
----------------
skatrak wrote:
Nit: Since you're updating this, other similar helpers return the concrete operation type.
```suggestion
static mlir::omp::LoopOp
```
Same comment for the other spots where you've replaced `void` with `mlir::Operation *`.
https://github.com/llvm/llvm-project/pull/133891
More information about the flang-commits
mailing list