[flang-commits] [clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

[Matt Arsenault via flang-commits]

arsenm wrote:

> * Move the MC emission functions in `TargetMachine` to `LLVMTargetMachine`. With the changes in this PR, we explicitly assume in both `addPassesToEmitFile` and `addPassesToEmitMC` that the `TargetMachine` is an `LLVMTargetMachine`; Hence it does not make sense for these functions to be present in the `TargetMachine` interface.

Was this already implicitly assumed? IIRC there was some layering reason why this is the way it was. There were previous attempts to merge these before, which were abandoned: 

https://lists.llvm.org/pipermail/llvm-dev/2017-October/117907.html

https://reviews.llvm.org/D38482
https://reviews.llvm.org/D38489

https://github.com/llvm/llvm-project/pull/110443