[flang-commits] [flang] [flang][debug] Support derived type components with box types. (PR #109424)

[Abid Qadeer via flang-commits]

================
@@ -13,6 +13,9 @@
 #include "flang/Optimizer/Dialect/FIRType.h"
 #include "flang/ISO_Fortran_binding_wrapper.h"
 #include "flang/Optimizer/Builder/Todo.h"
+#include "flang/Optimizer/CodeGen/DescriptorModel.h"
+#include "flang/Optimizer/CodeGen/DescriptorOffsets.h"
+#include "flang/Optimizer/CodeGen/TypeConverter.h"
----------------
abidh wrote:

Thanks for your comments. I have updated the PR and it does not use `getTypeSizeAndAlignment` to get the size for any type. We use LLVMTypeConverter to convert fieldTy into LLVM type and then use DataLayout to get the size. It all seems to works ok. My concern was whether it is safe to call `DataLayout::getTypeSize` on any type that is returned by `LLVMTypeConverter::convertType`. I did not see any problem with my testing but would be happy to add any type specific check.


https://github.com/llvm/llvm-project/pull/109424