[flang-commits] [flang] [llvm] [mlir] [OpenMPIRBuilder] Emit __atomic_load and __atomic_compare_exchange libcalls for complex types in atomic update (PR #92364)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Sat Sep 21 09:43:41 PDT 2024


https://github.com/kiranchandramohan commented:

I think we need to organize and test this patch a bit better.

1. Is the following sentence in the summary still correct or is the code from LLVM AtomicExpand?
```
We first refactor relevant functionality from Clang Codegen to LLVM Frontend, and then interface the OpenMPIRBuilder with the same. 
```
2. The test removed from Todo is an atomic read, why was it not added back?
3. The code change in OpenMPToLLVMIRTranslation.cpp is the Capture Code generation. There is no test for this. Also cand this change be shared with the Update code generation?
4. We need tests in the OpenMP IRBuilder and in MLIR for the changes.

https://github.com/llvm/llvm-project/pull/92364


More information about the flang-commits mailing list