[flang-commits] [clang] [clang-tools-extra] [flang] Fix OOM in FormatDiagnostic (2nd attempt) (PR #108866)

[via flang-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 08efa23083606dc0248c4a7dee7087fa96b29c04 57b1dabf3522eae47fd7f8ea26c12bf1a97819ab --extensions cpp,h -- clang/test/PCH/race-condition.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang/include/clang/Basic/Diagnostic.h clang/include/clang/Basic/DiagnosticIDs.h clang/include/clang/Basic/PartialDiagnostic.h clang/include/clang/Sema/Sema.h clang/lib/Basic/Diagnostic.cpp clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Basic/SourceManager.cpp clang/lib/Frontend/Rewrite/FixItRewriter.cpp clang/lib/Frontend/TextDiagnosticPrinter.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaBase.cpp clang/lib/Serialization/ASTReader.cpp clang/unittests/Basic/DiagnosticTest.cpp clang/unittests/Driver/DXCModeTest.cpp flang/lib/Frontend/TextDiagnosticPrinter.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Basic/Diagnostic.cpp b/clang/lib/Basic/Diagnostic.cpp
index ffb3cd4270..0bd6845085 100644
--- a/clang/lib/Basic/Diagnostic.cpp
+++ b/clang/lib/Basic/Diagnostic.cpp
@@ -551,15 +551,15 @@ DiagnosticBuilder::DiagnosticBuilder(const DiagnosticBuilder &D)
 
 Diagnostic::Diagnostic(const DiagnosticsEngine *DO,
                        const DiagnosticBuilder &DiagBuilder)
-    : DiagObj(DO), DiagLoc(DiagBuilder.DiagLoc),
-      DiagID(DiagBuilder.DiagID), FlagValue(DiagBuilder.FlagValue),
-      DiagStorage(*DiagBuilder.getStorage()) {}
+    : DiagObj(DO), DiagLoc(DiagBuilder.DiagLoc), DiagID(DiagBuilder.DiagID),
+      FlagValue(DiagBuilder.FlagValue), DiagStorage(*DiagBuilder.getStorage()) {
+}
 
 Diagnostic::Diagnostic(const DiagnosticsEngine *DO, SourceLocation DiagLoc,
                        unsigned DiagID, const DiagnosticStorage &DiagStorage,
                        StringRef StoredDiagMessage)
-    : DiagObj(DO), DiagLoc(DiagLoc), DiagID(DiagID),
-      DiagStorage(DiagStorage), StoredDiagMessage(StoredDiagMessage) {}
+    : DiagObj(DO), DiagLoc(DiagLoc), DiagID(DiagID), DiagStorage(DiagStorage),
+      StoredDiagMessage(StoredDiagMessage) {}
 
 DiagnosticConsumer::~DiagnosticConsumer() = default;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/108866