[flang-commits] [flang] [llvm] [Flang][OpenMP][Sema] Adding parsing and semantic support for scan directive. (PR #102792)
Sergio Afonso via flang-commits
flang-commits at lists.llvm.org
Fri Sep 13 06:24:30 PDT 2024
================
@@ -223,6 +225,9 @@ class OmpStructureChecker
const parser::OmpObjectList &ompObjectList);
void CheckPredefinedAllocatorRestriction(
const parser::CharBlock &source, const parser::Name &name);
+ void checkAndAddSymbolsToUsedInScanList(const parser::OmpObjectList &x);
+ void addModifiertoMap(const parser::OmpObjectList &x,
+ parser::OmpReductionClause::ReductionModifier &modifier);
----------------
skatrak wrote:
Nit: Follow capitalization conventions on this file. Also, I think the name for one of these methods can be improved, but feel free to name it differently from what I'm suggesting if you think it's better.
```suggestion
void CheckAndRegisterScanSymbols(const parser::OmpObjectList &x);
void AddModifierToMap(const parser::OmpObjectList &x,
parser::OmpReductionClause::ReductionModifier &modifier);
```
https://github.com/llvm/llvm-project/pull/102792
More information about the flang-commits
mailing list