[flang-commits] [flang] [flang][OpenMP] don't privatise loop index marked shared (PR #108176)
Leandro Lupori via flang-commits
flang-commits at lists.llvm.org
Wed Sep 11 13:05:13 PDT 2024
================
@@ -2121,15 +2121,18 @@ void OmpAttributeVisitor::CreateImplicitSymbols(
}
return lastDeclSymbol;
};
- auto makeSharedSymbol = [&]() {
+ auto makeSharedSymbol = [&](bool setFlag) {
----------------
luporl wrote:
`setFlag` shadows a member function parameter, which I find confusing.
It would be better to:
- Rename it to something like `addFlag`.
- Or change it to `std::optional<Symbol::Flag> flag`, to make it similar to `makePrivateSymbol = [&](Symbol::Flag flag)`.
https://github.com/llvm/llvm-project/pull/108176
More information about the flang-commits
mailing list