[flang-commits] [flang] [flang] Use LLVM dialect ops for stack save/restore in target-rewrite (PR #107879)
via flang-commits
flang-commits at lists.llvm.org
Tue Sep 10 07:00:43 PDT 2024
agozillon wrote:
> Nice, I hadn't noticed these operations existed.
>
> There are other places in flang that we use stacksave and stackrestore. If you don't plan to update these please could you make a ticket and assign to me so I don't forget.
Thank you for addressing this! When doing this it would be greatly appreciated if you utilise the alloca address spaces similar to this PR! As, otherwise it runs the risk of breaking ISEL for AMDGPU if pulled in, the lowering flow for AMDGPU gets a little angry and breaks when address spaces aren't adhered to.
https://github.com/llvm/llvm-project/pull/107879
More information about the flang-commits
mailing list