[flang-commits] [flang] [flang][OpenMP] Error out when CHARACTER type is used in atomic constructs (PR #113045)

via flang-commits flang-commits at lists.llvm.org
Sat Oct 19 07:40:05 PDT 2024


================
@@ -128,6 +128,7 @@ static void processOmpAtomicTODO(mlir::Type elementType,
                              Fortran::parser::OmpAtomicClauseList>()) {
     // Based on assertion for supported element types in OMPIRBuilder.cpp
     // createAtomicRead
+    // TODO: Enumerate remaining unsupported types for atomics
     mlir::Type unwrappedEleTy = fir::unwrapRefType(elementType);
     bool supportedAtomicType = fir::isa_trivial(unwrappedEleTy);
----------------
NimishMishra wrote:

Should we let this in? Or we are in a position to remove this? I didn't remove right now; thought to ask once.

https://github.com/llvm/llvm-project/pull/113045


More information about the flang-commits mailing list