[flang-commits] [flang] [flang][debug] Add support for common blocks. (PR #112398)

[Tom Eccles via flang-commits]

tblah wrote:

> > I think you could make the detection more robust by ensuring that the linkage attribute of the `fir.global` is `"common"`.
> 
> I actually had this check but later noticed during my testing that sometime that global would not have "common" linkage. IIRC it was when common block is declared inside a module.

Ahh good catch. My concern is that operation sequence you are matching looks quite generic. I wonder if we should add a unit attribute to fir.global which indicates whether it comes from a common block and set that during lowering?

https://github.com/llvm/llvm-project/pull/112398