[flang-commits] [flang] [mlir] [Flang][OpenMP] Support lowering of simd reductions (PR #112194)

[Kiran Chandramohan via flang-commits]

kiranchandramohan wrote:

> Thanks for the update. That isn't the normal "not yet implemented" message generated by the TODO macro but I think the error message now looks clean and easy enough to understand:

Does the Driver report this as a crash?


> > Thanks for the update. That isn't the normal "not yet implemented" message generated by the TODO macro but I think the error message now looks clean and easy enough to understand
> 
> Yes, we're triggering different errors when something is not yet supported in Flang lowering vs. in omp dialect translation to LLVM IR. Should we create an equivalent TODO macro for use there too?

Why don't we issue the TODO in flang lowering? This is best and uniform from the Flang point of view. We can remove the TODO when translation support is added.

https://github.com/llvm/llvm-project/pull/112194