[flang-commits] [flang] [mlir] [mlir][OpenMP] rewrite conversion of privatisation for omp.parallel (PR #111844)

[Kiran Chandramohan via flang-commits]

================
@@ -1421,12 +1450,57 @@ convertOmpParallel(omp::ParallelOp opInst, llvm::IRBuilderBase &builder,
             deferredStores, isByRef)))
       bodyGenStatus = failure();
 
+    // Apply copy region for firstprivate.
+    if (!privateBlockArgs.empty()) {
----------------
kiranchandramohan wrote:

Is this sufficient check for the existence of Firstprivate?

If the intention is to always create these blocks, should these blocks be created by the initial skeleton creation in  OpenMPIRBuilder?

https://github.com/llvm/llvm-project/pull/111844