[flang-commits] [flang] [mlir] [mlir][Transforms] Dialect conversion: add `originalType` param to materializations (PR #112128)

Markus Böck via flang-commits flang-commits at lists.llvm.org
Sun Oct 13 03:54:40 PDT 2024


https://github.com/zero9178 commented:

I see uses of `materializeTargetConversion` within normal conversion patterns where its non-obvious to me as to how that method should now be used.

With your example of "v2" replacing "v1", the adaptor of the conversion pattern would then receive "v2", is that right? 
Isn't t1 then also inaccessible to the conversion pattern? Or can the case you describe not happen during conversion pattern application OR should `materializeTargetConversion` not actually ever be called by conversion patterns?

https://github.com/llvm/llvm-project/pull/112128


More information about the flang-commits mailing list