[flang-commits] [flang] [mlir] [mlir][debug] Allow multiple DIGlobalVariableExpression on globals. (PR #111981)

Abid Qadeer via flang-commits flang-commits at lists.llvm.org
Fri Oct 11 06:49:55 PDT 2024


abidh wrote:

> Thanks! I added some nit comments.
> 
> I think the approach with a typed array attribute makes sense. There is already prior art for the alias analysis metadata.
> 
> What alternative did you have in mind?

As I mentioned in the comment above, I was thinking if I could make the argument to the build function more strongly typed. But using `ArrayRef<DIGlobalVariableExpressionAttr>` did not work out.

https://github.com/llvm/llvm-project/pull/111981


More information about the flang-commits mailing list