[flang-commits] [flang] [mlir] [mlir][NFC] Mark type converter in `populate...` functions as `const` (PR #111250)

[LLVM Continuous Integration via flang-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `mlir-s390x-linux` running on `systemz-1` while building `flang,mlir` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/117/builds/2546

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
179.511 [1633/4/3053] Building CXX object tools/mlir/lib/Conversion/SCFToSPIRV/CMakeFiles/obj.MLIRSCFToSPIRV.dir/SCFToSPIRVPass.cpp.o
179.560 [1632/4/3054] Building CXX object tools/mlir/lib/Dialect/Linalg/Transforms/CMakeFiles/obj.MLIRLinalgTransforms.dir/BufferizableOpInterfaceImpl.cpp.o
181.430 [1631/4/3055] Building CXX object tools/mlir/lib/Conversion/SPIRVToLLVM/CMakeFiles/obj.MLIRSPIRVToLLVM.dir/SPIRVToLLVMPass.cpp.o
181.463 [1630/4/3056] Building CXX object tools/mlir/lib/Dialect/Linalg/IR/CMakeFiles/obj.MLIRLinalgDialect.dir/ValueBoundsOpInterfaceImpl.cpp.o
182.778 [1629/4/3057] Building CXX object tools/mlir/lib/Conversion/SCFToSPIRV/CMakeFiles/obj.MLIRSCFToSPIRV.dir/SCFToSPIRV.cpp.o
189.326 [1628/4/3058] Building CXX object tools/mlir/lib/Conversion/SPIRVToLLVM/CMakeFiles/obj.MLIRSPIRVToLLVM.dir/ConvertLaunchFuncToLLVMCalls.cpp.o
189.361 [1627/4/3059] Building CXX object tools/mlir/lib/Conversion/TensorToLinalg/CMakeFiles/obj.MLIRTensorToLinalg.dir/TensorToLinalgPass.cpp.o
190.903 [1626/4/3060] Building CXX object tools/mlir/lib/Conversion/TensorToLinalg/CMakeFiles/obj.MLIRTensorToLinalg.dir/TensorToLinalg.cpp.o
190.949 [1625/4/3061] Building CXX object tools/mlir/lib/Conversion/TosaToArith/CMakeFiles/obj.MLIRTosaToArith.dir/TosaToArith.cpp.o
193.553 [1624/4/3062] Building CXX object tools/mlir/lib/Conversion/SPIRVToLLVM/CMakeFiles/obj.MLIRSPIRVToLLVM.dir/SPIRVToLLVM.cpp.o
FAILED: tools/mlir/lib/Conversion/SPIRVToLLVM/CMakeFiles/obj.MLIRSPIRVToLLVM.dir/SPIRVToLLVM.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/tools/mlir/lib/Conversion/SPIRVToLLVM -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Conversion/SPIRVToLLVM -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/include -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/llvm/include -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/tools/mlir/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/mlir/lib/Conversion/SPIRVToLLVM/CMakeFiles/obj.MLIRSPIRVToLLVM.dir/SPIRVToLLVM.cpp.o -MF tools/mlir/lib/Conversion/SPIRVToLLVM/CMakeFiles/obj.MLIRSPIRVToLLVM.dir/SPIRVToLLVM.cpp.o.d -o tools/mlir/lib/Conversion/SPIRVToLLVM/CMakeFiles/obj.MLIRSPIRVToLLVM.dir/SPIRVToLLVM.cpp.o -c /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
In file included from /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp:13:
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVM.h: In member function 'const mlir::LLVMTypeConverter* mlir::SPIRVToLLVMConversion<SPIRVOp>::getTypeConverter() const':
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVM.h:35:12: error: invalid 'static_cast' from type 'const mlir::TypeConverter*' to type 'const mlir::LLVMTypeConverter*'
   35 |     return static_cast<const LLVMTypeConverter *>(
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   36 |         ConversionPattern::getTypeConverter());
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVM.h:21:7: note: class type 'const mlir::LLVMTypeConverter' is incomplete
   21 | class LLVMTypeConverter;
      |       ^~~~~~~~~~~~~~~~~
198.868 [1624/3/3063] Building CXX object tools/mlir/lib/Conversion/TensorToSPIRV/CMakeFiles/obj.MLIRTensorToSPIRV.dir/TensorToSPIRVPass.cpp.o
211.026 [1624/2/3064] Building CXX object tools/mlir/lib/Conversion/TosaToLinalg/CMakeFiles/obj.MLIRTosaToLinalg.dir/TosaToLinalg.cpp.o
214.779 [1624/1/3065] Building CXX object tools/mlir/lib/Dialect/Linalg/TransformOps/CMakeFiles/obj.MLIRLinalgTransformOps.dir/LinalgTransformOps.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/111250