[flang-commits] [flang] [flang][OpenMP] Rewrite `omp.loop` to semantically equivalent ops (PR #115443)

[Sergio Afonso via flang-commits]

================
@@ -0,0 +1,68 @@
+//===-- include/flang/Common/OpenMP-utils.h --------------------*- C++ -*-====//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef FORTRAN_COMMON_OPENMP_UTILS_H_
+#define FORTRAN_COMMON_OPENMP_UTILS_H_
+
+#include "flang/Semantics/symbol.h"
+
+#include "mlir/IR/Builders.h"
+#include "mlir/IR/Value.h"
+
+#include "llvm/ADT/ArrayRef.h"
+
+namespace Fortran::openmp::common {
----------------
skatrak wrote:

Nit: Everywhere else in this directory, `Fortran::common` is the only namespace defined (even for other OpenMP definitions). I'd suggest doing the same here and perhaps renaming these definitions to include "OpenMP" in their names instead, like "OpenMPEntryBlockArgsEntry".

I'm not against creating an `openmp` namespace in `Fortran`, but this would be the only place where that would be done. If you still think this is something we want to do, consider following the existing directory hierarchy and rename this to `Fortran::common::openmp` instead.

https://github.com/llvm/llvm-project/pull/115443