[flang-commits] [flang] [Flang] [Semantics] [OpenMP] Added missing semantic check with nested target region. (PR #115344)

Raghu Maddhipatla via flang-commits flang-commits at lists.llvm.org
Wed Nov 20 09:02:35 PST 2024


raghavendhra wrote:

> > > Issue semantic warning for any combination of nested OMP TARGET directives inside an OMP TARGET DATA directive and vice versa.
> > 
> > 
> > Is there an error in the description? It's fine to nest `target` in `target data`.
> 
> Thank you for your review Michael!
> 
> There is already existent warning being issued for OMP TARGET DATA inside an OMP TARGET region here in the upstream https://github.com/llvm/llvm-project/blob/a8a1e9033a902d961ad050a139b97ac0319b9e25/flang/test/Semantics/OpenMP/nested-target.f90#L32C3-L39C19
> 
> Is this existent test case is also incorrectly issuing warning and should be changed to allow OMP TARGET DATA nested inside OMP TARGET region?

Upon discussion with Michael Klemm offline, we decided,

> PR only creates the warning for the case of target data being inside target, 

https://github.com/llvm/llvm-project/pull/115344


More information about the flang-commits mailing list