[flang-commits] [flang] [flang][OpenMP]Add parsing support for MAP(MAPPER(name) ...) (PR #116274)

Tom Eccles via flang-commits flang-commits at lists.llvm.org
Fri Nov 15 03:07:26 PST 2024


================
@@ -3718,7 +3721,8 @@ struct OmpMapClause {
   // The checks for satisfying those constraints are deferred to semantics.
   // In OpenMP 5.2 the non-comma syntax has been deprecated: keep the
   // information about separator presence to emit a diagnostic if needed.
-  std::tuple<std::optional<std::list<TypeModifier>>,
+  std::tuple<OmpMapperIdentifier, // Mapper name
----------------
tblah wrote:

It reads a bit strangely to me that the optional mapper identifier looks non-optional (if one doesn't look up at the type definition). Could the `std::optional` be moved outside of the type so it is visible here?

Don't worry about it if it becomes a headache to do - this is very nitpicky

https://github.com/llvm/llvm-project/pull/116274


More information about the flang-commits mailing list