[flang-commits] [flang] [mlir] [mlir] Align num elements type to LLVM ArrayType (PR #93230)

Oleksandr Alex Zinenko via flang-commits flang-commits at lists.llvm.org
Wed May 29 09:35:19 PDT 2024


================
@@ -632,8 +632,25 @@ llvm::Constant *mlir::LLVM::detail::getLLVMConstant(
           llvm::ElementCount::get(numElements, /*Scalable=*/isScalable), child);
     if (llvmType->isArrayTy()) {
       auto *arrayType = llvm::ArrayType::get(elementType, numElements);
-      SmallVector<llvm::Constant *, 8> constants(numElements, child);
-      return llvm::ConstantArray::get(arrayType, constants);
+      if (child->isZeroValue()) {
+        return llvm::ConstantAggregateZero::get(arrayType);
+      } else {
+        if (llvm::ConstantDataSequential::isElementTypeCompatible(elementType)) {
+          // TODO: Handle all compatible types. This code only handle i32.
----------------
ftynse wrote:

```suggestion
          // TODO: Handle all compatible types. This code only handles i32.
```

https://github.com/llvm/llvm-project/pull/93230


More information about the flang-commits mailing list