[flang-commits] [flang] [flang] Fix execute_command_line cmdstat is not set when error occurs (PR #93023)

Daniel Chen via flang-commits flang-commits at lists.llvm.org
Wed May 29 06:55:00 PDT 2024


DanielCChen wrote:

> Correct, but I'm not sure if its a good idea to use `popen` to capture the output (and only store it to `cmdstat` when error occurs)
> It would be better if there is a detailed `cmdmsg` to match the actual meaning of the error. but in case of an error, the error message would shows up in the console, maybe adding "Invalid command line: consider checking for exitstat and console printout"

My intention was to separate the error messages of a failed command execution from the command doesn't exist at all. It is a minor issue though.

https://github.com/llvm/llvm-project/pull/93023


More information about the flang-commits mailing list