[flang-commits] [flang] [flang][OpenMP] Adapt OMPMapInfoFinalization to run on all top level ops (PR #93545)

[via flang-commits]

https://github.com/agozillon commented:

I don't have any issues with the change from what I can see, if it breaks any of the existing runtime or lit tests we will likely know about it soon enough! Although, from what I can see/understand I doubt that'd be the case :-)

However, one question I may have is, will this result in walks on the same MapInfoOp more than once? Might be a dumb question, but I am unfamiliar with addNestedPassToAllTopLevelOperations unfortunately. 

The pass sadly isn't really setup to be executed multiple times on the same MapInfoOp, so if it triggers on a ModuleOp walks the MapInfoOps, and then triggers on the FuncOp functions contained within that ModuleOp, there may be an issue. As it'll expand certain (BoxTypes) MapInfoOp multiple times, which will result in multiple maps of it, which in some cases will work fine, others not so much.

Otherwise, I have no issues with this PR of course and it LGTM, outside of that question! And I am more than happy to hit approve after the above question has been answered!



https://github.com/llvm/llvm-project/pull/93545