[flang-commits] [flang] [flang] Fix execute_command_line cmdstat is not set when error occurs (PR #93023)

Yi Wu via flang-commits flang-commits at lists.llvm.org
Tue May 28 02:35:21 PDT 2024


yi-wu-arm wrote:

>but the error message Invalid command line seems not quite accurate.

Correct, but I'm not sure if its a good idea to use `popen` to capture the output (and only store it to `cmdstat` when error occurs)
It would be better if there is a detailed `cmdmsg` to match the actual meaning of the error. but in case of an error, the error message would shows up in the console, maybe adding "Invalid command line: consider checking for exitstat and console printout"


https://github.com/llvm/llvm-project/pull/93023


More information about the flang-commits mailing list