[flang-commits] [flang] 0eca265 - [flang][cuda] Fix memory side effects on cuf.data_transfer op (#92928)
via flang-commits
flang-commits at lists.llvm.org
Tue May 21 09:59:40 PDT 2024
Author: Valentin Clement (バレンタイン クレメン)
Date: 2024-05-21T09:59:35-07:00
New Revision: 0eca2655843e1b79e6c65c7239bce8c9a1509568
URL: https://github.com/llvm/llvm-project/commit/0eca2655843e1b79e6c65c7239bce8c9a1509568
DIFF: https://github.com/llvm/llvm-project/commit/0eca2655843e1b79e6c65c7239bce8c9a1509568.diff
LOG: [flang][cuda] Fix memory side effects on cuf.data_transfer op (#92928)
The memory side effects on the `cuf.data_transfer` operation were
swapped between the src and dst operands. We read from source and write
to destination not the opposite.
Added:
Modified:
flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td
Removed:
################################################################################
diff --git a/flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td b/flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td
index 72157bce4f768..1c98b4131a139 100644
--- a/flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td
+++ b/flang/include/flang/Optimizer/Dialect/CUF/CUFOps.td
@@ -154,8 +154,8 @@ def cuf_DataTransferOp : cuf_Op<"data_transfer", []> {
```
}];
- let arguments = (ins Arg<AnyReferenceLike, "", [MemWrite]>:$src,
- Arg<AnyReferenceLike, "", [MemRead]>:$dst,
+ let arguments = (ins Arg<AnyReferenceLike, "", [MemRead]>:$src,
+ Arg<AnyReferenceLike, "", [MemWrite]>:$dst,
cuf_DataTransferKindAttr:$transfer_kind);
let assemblyFormat = [{
More information about the flang-commits
mailing list