[flang-commits] [flang] [NFC][flang][runtime] Avoid recursion in EditCharacterOutput and EditLogicalOutput. (PR #92806)
via flang-commits
flang-commits at lists.llvm.org
Mon May 20 11:51:03 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-flang-runtime
Author: Slava Zakharin (vzakhari)
<details>
<summary>Changes</summary>
…LogicalOutput.
---
Full diff: https://github.com/llvm/llvm-project/pull/92806.diff
1 Files Affected:
- (modified) flang/runtime/edit-output.cpp (+5-2)
``````````diff
diff --git a/flang/runtime/edit-output.cpp b/flang/runtime/edit-output.cpp
index 13ab91fc56ead..6b24c56483185 100644
--- a/flang/runtime/edit-output.cpp
+++ b/flang/runtime/edit-output.cpp
@@ -832,8 +832,11 @@ RT_API_ATTRS bool EditLogicalOutput(
reinterpret_cast<const unsigned char *>(&truth), sizeof truth);
case 'A': { // legacy extension
int truthBits{truth};
- return EditCharacterOutput(
- io, edit, reinterpret_cast<char *>(&truthBits), sizeof truthBits);
+ int len{sizeof truthBits};
+ int width{edit.width.value_or(len)};
+ return EmitRepeated(io, ' ', std::max(0, width - len)) &&
+ EmitEncoded(
+ io, reinterpret_cast<char *>(&truthBits), std::min(width, len));
}
default:
io.GetIoErrorHandler().SignalError(IostatErrorInFormat,
``````````
</details>
https://github.com/llvm/llvm-project/pull/92806
More information about the flang-commits
mailing list