[flang-commits] [flang] [Flang][OpenMP] Fix lastprivate store issue (PR #92777)

Tom Eccles via flang-commits flang-commits at lists.llvm.org
Mon May 20 09:59:30 PDT 2024


================
@@ -226,7 +226,9 @@ void DataSharingProcessor::insertLastPrivateCompare(mlir::Operation *op) {
       auto ifOp = firOpBuilder.create<fir::IfOp>(loc, cmpOp, /*else*/ false);
       firOpBuilder.setInsertionPointToStart(&ifOp.getThenRegion().front());
       assert(loopIV && "loopIV was not set");
-      firOpBuilder.create<fir::StoreOp>(loopOp.getLoc(), v, loopIV);
+      mlir::Value cvtV = firOpBuilder.createConvert(
----------------
tblah wrote:

nit: it would be cleaner to use `fir::FirOpBUilder::createStoreWithConvert` here

https://github.com/llvm/llvm-project/pull/92777


More information about the flang-commits mailing list