[flang-commits] [flang] [flang][OpenMP] Try to unify induction var privatization for sequential loops inside parallel regions. (PR #91116)
Leandro Lupori via flang-commits
flang-commits at lists.llvm.org
Wed May 8 05:35:54 PDT 2024
https://github.com/luporl commented:
I like the idea of having `allPrivatizedSymbols` to let the privatized symbols be handled in the same way.
But the way it's implemented here, it won't work correctly for all cases.
`collectSymbols` will only collect:
1. Symbols whose DSA match that of a `default` clause
2. Symbols marked with OmpImplicit
So, as pre-determined symbols are never implicit, in a construct without a `default` or other explicit DSA clause, such as `private`, pre-determined symbols won't be collected for privatization.
IIUC, you want to collect and privatize all pre-determined symbols now, right?
If that's the case, you'll need to refactor `collectSymbols` and call it again, with flag = OmpPreDetermined.
https://github.com/llvm/llvm-project/pull/91116
More information about the flang-commits
mailing list